Added TransferLowStatPokemon #378
Conversation
|
Added berry fix in the last commit. It's now a config value just like balls and potions. Also added (and commented out) the code for the rest of the berries since they aren't implemented yet. |
|
Have you tested this? Can you take a look over?https://github.com/Valmere/PokeMobBot/blob/development/PoGo.PokeMobBot.Logic/Tasks/TransferLowStatPokemon.cs#L26 Needs to be translated, right, fam? |
|
Wasn't thinking about our international users, will take a look at possible translation issues. Fairly certain the berry fix can be cherry picked though |
|
Object reference not set to an instance of an object. Is what im getting at |
|
Gone through the code and this, in my opinion is unnecessary. The code to transfer properly needs to be fixed in the current mobbot. The reason it evolved from the "old way" is because we needed to better filter iv over cp if thats what was desired. If im correct, what you have done is wind back the hands of time to something people wanted to evolve away from? Currently it does not priorities IvoverCp at all.(broken mobbot) Most people don't care max cp on a rubish Iv%. If i m looking at your code corectly i cannot force it to transfer anything above 10cp and below 99% IV. When thats what i think everyone wants to see. It actually working. Just my opinion and request, please do correct me if i am wrong. i mean no disrespect at all. |
|
Those that like the TransferDuplicate option can continue to use it - this is an option with an on/off setting that in my opinion works better for keeping a team of strong pokemon. Transferring pokemon above 10CP and below 99%IV is easily done by setting the CP minimum to something unobtainable like 5k and the IV minimum to 100. I'm currently keeping anything above 1500CP or 95% IV as those stats are good enough for holding random gyms: |
|
I guess I need some more opinions here. |
|
It's got conflicts with something now, i'll close this and PR the berry thing first |
Alternative to TransferDuplicatePokemon, if you don't mind having 20 vaporeon or gyarados as long as they're strong. Will transfer pokemon that are below the KeepMinCp threshold or below the KeepMinIvPercentage threshold with PrioritizeIvOverCp set to true.
To be used instead of TransferDuplicatePokemon for people that don't mind having 20 vaporeon or gyarados as their strongest. Will not transfer pokemon in the DoNotTransfer list or the PokemonToEvolve list if KeepPokemonsThatCanEvolve is set to true.
It's now a config value just like balls/potions/revives. Also added in the rest of the berries but commented it out due to the berries not being implemented yet, but the code's ready for when they are.
|
put berry fixes into their own PR: #444 will close this one and make a new one for just the TransferLowStats |
Works similar to the old TransferType = CP. Set TransferDuplicatePokemon to false and TransferLowStatPokemon to true in your config once it updates, then use the KeepMinCp and KeepMinIvPercentage (with PrioritizeIvOverCp set to true) to filter what you don't want. It will not toss pokemon on your DoNotTransfer list nor pokemon on the Evolve list if KeepPokemonsThatCanEvolve is true.
Solves the full inventory problem for people that have a full stash of pokemon.
That's wiki level information tbhfam, if you still can't get it to work I'm sorry